added WorkflowServiceGrpc and IWorkflowServiceV4 #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Groxx,
abhishekj720,
natemort,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
|
Is this a complete switch to GRPC, so we're throwing away thrift? |
I finally get the chance to add the unit test for mappers. To answer your question, I mainly need reviews on 1:1 comparison of thrift vs newly added entities. Others are captured by mappers tests. |
natemort
reviewed
Jun 11, 2025
build.gradle
Outdated
| @@ -89,6 +89,11 @@ dependencies { | |||
| compile group: 'com.google.api.grpc', name: 'proto-google-common-protos', version: '2.10.0' | |||
| compile group: 'com.google.protobuf', name: 'protobuf-java-util', version: '3.21.9' | |||
| compile group: 'com.google.oauth-client', name: 'google-oauth-client', version: '1.35.0' | |||
| compile group: 'org.projectlombok', name: 'lombok', version: '1.18.30' | |||
There was a problem hiding this comment.
We should only need the compileOnly dependency. We don't want to include this at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
BaseError, which is a catchall similar toTException.Plan
Why?
Thrift deprecation work
How did you test it?
Unit Test on mappers from ClientObjects to ProtoObjects
Potential risks
Release notes
Documentation Changes